Move calendar initialization to server startup #5037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
added
NoDocumentationNeeded
NoReleaseNotesNeeded
cpwright
previously approved these changes
Jan 12, 2024
devinrsmith
requested review from
chipkent,
jmao-denver and
rcaudy
as code owners
chipkent
previously approved these changes
Jan 12, 2024
engine/time/src/main/java/io/deephaven/time/calendar/BusinessCalendarXMLParser.java
Outdated
Show resolved
Hide resolved
devinrsmith
force-pushed
the
calendars-dagger-configuration
branch
from
68859ac to
bc49c3e
Compare
chipkent
reviewed
Jan 16, 2024
engine/time/src/test/java/io/deephaven/time/calendar/CalendarInit.java
Outdated
Show resolved
Hide resolved
chipkent
reviewed
Jan 16, 2024
Integrations/src/test/java/io/deephaven/integrations/python/CalendarsHelper.java
Outdated
Show resolved
Hide resolved
Plot/src/test/java/io/deephaven/plot/axistransformations/CalendarInit.java
Outdated
Show resolved
Hide resolved
engine/time/src/test/java/io/deephaven/time/calendar/CalendarInit.java
Outdated
Show resolved
Hide resolved
| import io.deephaven.time.calendar.BusinessCalendar; | ||
| import io.deephaven.time.calendar.Calendars; | ||
|
|
||
| public final class CalendarsHelper { |
There was a problem hiding this comment.
Test configuration for calendars feels like it is spread all over the place. CalendarsHelper and two different CalendarInit do roughly the same thing in different ways, including the opaque, undocumented noop() method. Is there any reason that all of this logic shouldn't be consolidated into a single Calendars.addCalendarsFromConfiguration() method?
Integrations/src/test/java/io/deephaven/integrations/python/CalendarsHelper.java
Outdated
Show resolved
Hide resolved
Integrations/src/test/java/io/deephaven/integrations/python/CalendarsHelper.java
Outdated
Show resolved
Hide resolved
chipkent
approved these changes
Jan 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.